cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder.
Convert Layer::children() calls to using LayerListIterator.

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b365de0a276e993e014c561183c6e8beb2b99051
Cr-Commit-Position: refs/heads/master@{#390461}

[sunxd, 2016-04-26 14:39:39]

Description was changed from

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder

BUG=600390
==========

to

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-04-26 19:43:29]

Description was changed from

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder.
Convert Layer::children() calls to using LayerListIterator.

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-04-26 19:43:29]

sunxd@chromium.org changed reviewers:
+ ajuma@chromium.org, jaydasika@chromium.org, vollick@chromium.org

[ajuma, 2016-04-27 18:03:05]

lgtm

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:1075: return NULL;
nit: nullptr

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:1086: return NULL;
nullptr

[jaydasika, 2016-04-27 18:21:10]

lgtm

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/draw_property...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/draw_property...
cc/trees/draw_property_utils.cc:378: UpdateRenderSurfaceForLayer(effect_tree,
true, layer);
This and ValidateRenderSurfacesRecursive can be deleted and we can both update
and validate in a single iteration that can go into the caller :
UpdateRenderSurfaces. (ComputeVisibleRects does the same thing for impl-side)

[jaydasika, 2016-04-27 18:36:03]

2 more nits.

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:169: static void
PreCalculateMetaInformationInternal(
This should be a ForTesting function.

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:1068:
PropertyTreeBuilder::PreCalculateMetaInformation(LayerImpl* root_layer) {
Should be a ForTesting function

[sunxd, 2016-04-28 00:18:51]

The CQ bit was checked by sunxd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 00:19:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921503005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921503005/140001

[commit-bot: I haz the power, 2016-04-28 01:09:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 01:09:39]

Dry run: This issue passed the CQ dry run.

[sunxd, 2016-04-28 14:21:54]

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:169: static void
PreCalculateMetaInformationInternal(
On 2016/04/27 18:36:03, jaydasika wrote:
> This should be a ForTesting function.

Done.

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:1068:
PropertyTreeBuilder::PreCalculateMetaInformation(LayerImpl* root_layer) {
On 2016/04/27 18:36:03, jaydasika wrote:
> Should be a ForTesting function

Done.

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:1075: return NULL;
On 2016/04/27 18:03:05, ajuma wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1921503005/diff/120001/cc/trees/property_tree...
cc/trees/property_tree_builder.cc:1086: return NULL;
On 2016/04/27 18:03:05, ajuma wrote:
> nullptr

Done.

[sunxd, 2016-04-28 15:39:39]

The CQ bit was checked by sunxd@chromium.org

[sunxd, 2016-04-28 15:39:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1921503005/#ps140001
(title: "Resolve comments")

[commit-bot: I haz the power, 2016-04-28 15:39:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921503005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921503005/140001

[sunxd, 2016-04-28 15:44:41]

The CQ bit was unchecked by sunxd@chromium.org

[sunxd, 2016-04-28 18:13:19]

The CQ bit was checked by sunxd@chromium.org

[sunxd, 2016-04-28 18:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1921503005/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-28 18:13:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921503005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921503005/160001

[commit-bot: I haz the power, 2016-04-28 18:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 18:16:17]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sunxd, 2016-04-28 18:35:53]

The CQ bit was checked by sunxd@chromium.org

[sunxd, 2016-04-28 18:35:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1921503005/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-28 18:36:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921503005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921503005/180001

[commit-bot: I haz the power, 2016-04-28 18:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 18:45:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sunxd, 2016-04-28 18:57:51]

sunxd@chromium.org changed reviewers:
+ enne@chromium.org

[sunxd, 2016-04-28 18:58:45]

Add enne@ for the change in content/renderer/gpu

[enne (OOO), 2016-04-28 20:23:44]

lgtm

[sunxd, 2016-04-28 20:24:49]

The CQ bit was checked by sunxd@chromium.org

[commit-bot: I haz the power, 2016-04-28 20:25:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921503005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921503005/180001

[commit-bot: I haz the power, 2016-04-28 20:33:10]

Description was changed from

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder.
Convert Layer::children() calls to using LayerListIterator.

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder.
Convert Layer::children() calls to using LayerListIterator.

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-28 20:33:12]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-04-30 17:20:39]

Patchset 10 (id:??) landed as
https://crrev.com/b365de0a276e993e014c561183c6e8beb2b99051
Cr-Commit-Position: refs/heads/master@{#390461}

[commit-bot: I haz the power, 2016-04-30 17:57:11]

Description was changed from

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder.
Convert Layer::children() calls to using LayerListIterator.

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move main thread hierarchy dependencies into PropertyTreeBuilder

Move PreCalculateMetaInformation to PropertyTreeBuilder.
Convert Layer::children() calls to using LayerListIterator.

BUG=600390
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/b365de0a276e993e014c561183c6e8beb2b99051
Cr-Commit-Position: refs/heads/master@{#390461}
==========