Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1921503002: [Binding][PerformanceTest] Fix post-message.html to wait messages' responses. (Closed)

Created:
4 years, 8 months ago by peria
Modified:
4 years, 8 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the behavior of post-message.html Before this CL, the test sent 10k messages and finished. In this style, we had two issues; 1. it did not measure performance of postMessage 2. it remained many message tasks in pool, and regressed following tests. This CL makes it to wait all messages' responses arrives, and fixes the issues. BUG=601832 Committed: https://crrev.com/e3fe1b6186a589a8f5d020b2e4d8eaee8fe48ddd Cr-Commit-Position: refs/heads/master@{#389430}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M third_party/WebKit/PerformanceTests/Bindings/post-message.html View 1 chunk +31 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
peria
PTL
4 years, 8 months ago (2016-04-25 05:17:20 UTC) #4
Yuki
lgtm
4 years, 8 months ago (2016-04-25 05:37:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921503002/20001
4 years, 8 months ago (2016-04-25 05:39:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-25 08:17:23 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 08:18:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3fe1b6186a589a8f5d020b2e4d8eaee8fe48ddd
Cr-Commit-Position: refs/heads/master@{#389430}

Powered by Google App Engine
This is Rietveld 408576698