Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: appengine/findit/model/wf_try_job_data.py

Issue 1921493002: [Findit] Adding improved error detection to MonitorTryJobPipeline (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/wf_try_job_data.py
diff --git a/appengine/findit/model/wf_try_job_data.py b/appengine/findit/model/wf_try_job_data.py
index cf9a4d588e157fac37626fe95a0c34ec48874f5c..2182651a453be704825eeefdce4885a5a1afebab 100644
--- a/appengine/findit/model/wf_try_job_data.py
+++ b/appengine/findit/model/wf_try_job_data.py
@@ -31,15 +31,11 @@ class WfTryJobData(ndb.Model):
try_job_url = ndb.StringProperty(indexed=False)
# Error message and reason, if any.
error = ndb.JsonProperty(indexed=False)
+ # Error code if anything went wrong with the try job.
+ error_code = ndb.IntegerProperty(indexed=True)
# The last buildbucket build response received.
last_buildbucket_response = ndb.JsonProperty(indexed=False, compressed=True)
- # TODO(lijeffrey): We may want to determine whether or not a try job
- # was triggered as a redo of another if the first failed to find a culprit.
- # For example, if passing compile targets yields no results, a redo without
- # compile targets may be attempted to find the culprit CL and the occurrence
- # documented in a queryable manner.
-
@staticmethod
def _CreateKey(build_id): # pragma: no cover
return ndb.Key('WfTryJobData', build_id)
« no previous file with comments | « appengine/findit/common/waterfall/try_job_error.py ('k') | appengine/findit/waterfall/monitor_try_job_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698