appengine/findit/model/try_job_error.py - Issue 1921493002: [Findit] Adding improved error detection to MonitorTryJobPipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/try_job_error.py

Issue 1921493002: [Findit] Adding improved error detection to MonitorTryJobPipeline (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/model/try_job_error.py

diff --git a/appengine/findit/waterfall/try_job_type.py b/appengine/findit/model/try_job_error.py

similarity index 50%

copy from appengine/findit/waterfall/try_job_type.py

copy to appengine/findit/model/try_job_error.py

index 6da35e2f2fe910e29e4e96adb766ec56787df0db..f9dca5874b09cfce1d6935077ff5b9845bc0e981 100644

--- a/appengine/findit/waterfall/try_job_type.py

+++ b/appengine/findit/model/try_job_error.py

@@ -2,7 +2,9 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-class TryJobType(object):

- COMPILE = 'compile'

- TEST = 'test'

+# Represents possible error codes for what can go wrong during try jobs.

stgao 2016/04/25 23:44:39 Could we move this to findit/common/waterfall/ ins

lijeffrey 2016/04/26 00:50:07 Done.

+UNKNOWN = 10

+TIMEOUT = 20

+BUILDBUCKET_ERROR = 30

+TRYBOT_NOT_FOUND = 40

+INFRA_FAILURE = 50

« no previous file with comments | « no previous file | appengine/findit/model/wf_try_job_data.py » ('j') | appengine/findit/waterfall/monitor_try_job_pipeline.py » ('J')