Source/core/svg/SVGPatternElement.cpp - Issue 192143002: Use isSVG*Element() helpers more in SVG code (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGPatternElement.cpp

Issue 192143002: Use isSVG*Element() helpers more in SVG code (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGPatternElement.cpp

diff --git a/Source/core/svg/SVGPatternElement.cpp b/Source/core/svg/SVGPatternElement.cpp

index 9153a2f8fb72ad23776976676f8efb295c936bb8..fa6db5cd4f5a454a45bf7a25a58a142d39bb246e 100644

--- a/Source/core/svg/SVGPatternElement.cpp

+++ b/Source/core/svg/SVGPatternElement.cpp

@@ -192,8 +192,8 @@ void SVGPatternElement::collectPatternAttributes(PatternAttributes& attributes)

// Respect xlink:href, take attributes from referenced element

Node* refNode = SVGURIReference::targetElementFromIRIString(current->hrefString(), document());

- if (refNode && refNode->hasTagName(SVGNames::patternTag)) {

- current = toSVGPatternElement(const_cast<const Node*>(refNode));

+ if (isSVGPatternElement(refNode)) {

+ current = toSVGPatternElement(refNode);

// Cycle detection

if (processedPatterns.contains(current))