Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Issue 192143002: Use isSVG*Element() helpers more in SVG code (Part 2) (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Use isSVG*Element() helpers more in SVG code (Part 2) Use isSVG*Element() helpers more in SVG code. This makes the code clearer / simpler. R=pdr@chromium.org, pdr BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168800

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -43 lines) Patch
M Source/core/svg/SVGGlyphElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGHKernElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 5 chunks +7 lines, -8 lines 0 comments Download
M Source/core/svg/SVGVKernElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Inactive
6 years, 9 months ago (2014-03-09 01:56:25 UTC) #1
pdr.
LGTM https://codereview.chromium.org/192143002/diff/1/Source/core/svg/graphics/SVGImage.cpp File Source/core/svg/graphics/SVGImage.cpp (right): https://codereview.chromium.org/192143002/diff/1/Source/core/svg/graphics/SVGImage.cpp#newcode145 Source/core/svg/graphics/SVGImage.cpp:145: while (Node* node = walker.get()) { It looks ...
6 years, 9 months ago (2014-03-09 02:25:39 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-09 02:25:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/192143002/1
6 years, 9 months ago (2014-03-09 02:26:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 02:28:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-09 02:28:10 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-09 02:45:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/192143002/1
6 years, 9 months ago (2014-03-09 02:45:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 03:27:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-09 03:27:13 UTC) #10
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-09 03:38:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/192143002/1
6 years, 9 months ago (2014-03-09 03:38:11 UTC) #12
Inactive
6 years, 9 months ago (2014-03-09 04:27:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 manually as r168800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698