Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921363002: 🐼 Regenerate .device.isolate when .runtime_deps changes. (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Regenerate .device.isolate when .runtime_deps changes. BUG=589318 Committed: https://crrev.com/6bc322a022a8a957d44253842a217df2682b5110 Cr-Commit-Position: refs/heads/master@{#389839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M testing/test.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
agrieve
4 years, 7 months ago (2016-04-26 18:06:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921363002/1
4 years, 7 months ago (2016-04-26 18:06:43 UTC) #4
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-26 18:47:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 19:04:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921363002/1
4 years, 7 months ago (2016-04-26 19:05:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 19:11:39 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 19:13:11 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6bc322a022a8a957d44253842a217df2682b5110
Cr-Commit-Position: refs/heads/master@{#389839}

Powered by Google App Engine
This is Rietveld 408576698