Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1921343002: Fix product build compile and ensure all tests run cleanly again. (Closed)

Created:
4 years, 7 months ago by siva
Modified:
4 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix product build compile and ensure all tests run cleanly again. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/4547165abe4195368cf27a2b17217f625de8fdbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M runtime/vm/flag_list.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 3 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M samples/samples.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 7 months ago (2016-04-26 17:53:15 UTC) #2
srdjan
lgtm
4 years, 7 months ago (2016-04-26 22:35:55 UTC) #3
siva
4 years, 7 months ago (2016-04-26 23:45:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4547165abe4195368cf27a2b17217f625de8fdbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698