Source/core/svg/SVGAltGlyphElement.cpp - Issue 192133002: Use isSVG*Element() helpers more in SVG code (Part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAltGlyphElement.cpp

Issue 192133002: Use isSVG*Element() helpers more in SVG code (Part 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAltGlyphElement.cpp

diff --git a/Source/core/svg/SVGAltGlyphElement.cpp b/Source/core/svg/SVGAltGlyphElement.cpp

index 17b6ea9766ca91b3e4d65854ba365353fdfc0d6b..7686d1d82f96e3d0087641e9b7b3473e6d511fda 100644

--- a/Source/core/svg/SVGAltGlyphElement.cpp

+++ b/Source/core/svg/SVGAltGlyphElement.cpp

@@ -79,13 +79,12 @@ bool SVGAltGlyphElement::hasValidGlyphElements(Vector<AtomicString>& glyphNames)

if (!element)

return false;

- if (element->hasTagName(SVGNames::glyphTag)) {

+ if (isSVGGlyphElement(*element)) {

glyphNames.append(target);

return true;

}

- if (element->hasTagName(SVGNames::altGlyphDefTag)

- && toSVGAltGlyphDefElement(element)->hasValidGlyphElements(glyphNames))

+ if (isSVGAltGlyphDefElement(*element) && toSVGAltGlyphDefElement(*element).hasValidGlyphElements(glyphNames))

return true;

return false;