Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: Source/core/svg/SVGAltGlyphElement.cpp

Issue 192133002: Use isSVG*Element() helpers more in SVG code (Part 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAltGlyphDefElement.cpp ('k') | Source/core/svg/SVGAltGlyphItemElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 return new RenderSVGTSpan(this); 72 return new RenderSVGTSpan(this);
73 } 73 }
74 74
75 bool SVGAltGlyphElement::hasValidGlyphElements(Vector<AtomicString>& glyphNames) const 75 bool SVGAltGlyphElement::hasValidGlyphElements(Vector<AtomicString>& glyphNames) const
76 { 76 {
77 AtomicString target; 77 AtomicString target;
78 Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefA ttr), document(), &target); 78 Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefA ttr), document(), &target);
79 if (!element) 79 if (!element)
80 return false; 80 return false;
81 81
82 if (element->hasTagName(SVGNames::glyphTag)) { 82 if (isSVGGlyphElement(*element)) {
83 glyphNames.append(target); 83 glyphNames.append(target);
84 return true; 84 return true;
85 } 85 }
86 86
87 if (element->hasTagName(SVGNames::altGlyphDefTag) 87 if (isSVGAltGlyphDefElement(*element) && toSVGAltGlyphDefElement(*element).h asValidGlyphElements(glyphNames))
88 && toSVGAltGlyphDefElement(element)->hasValidGlyphElements(glyphNames))
89 return true; 88 return true;
90 89
91 return false; 90 return false;
92 } 91 }
93 92
94 } 93 }
95 94
96 #endif 95 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAltGlyphDefElement.cpp ('k') | Source/core/svg/SVGAltGlyphItemElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698