Issue 192123002: chromeos: A little more cleanup for EventRewriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192123002: chromeos: A little more cleanup for EventRewriter. (Closed)

Created:
6 years, 9 months ago by sadrul

Modified:
6 years, 9 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: A little more cleanup for EventRewriter. The EventRewriter itself is a MessagePumpObserver now, so it does not have to depend on XInputHierarchyChangedEventListener to know what device a key event came from. Remove the relevant method from DeviceHierarchyObserver interface. BUG=none R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255813

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -58 lines)			Patch
M	chrome/browser/chromeos/device_hierarchy_observer.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/events/event_rewriter.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/events/event_rewriter.cc	View	3 chunks	+21 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/events/xinput_hierarchy_changed_event_listener.cc	View	4 chunks	+4 lines, -35 lines	0 comments	Download
M	chrome/browser/chromeos/system/pointer_device_observer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 9 months ago (2014-03-09 03:05:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r255813 (presubmit successful).

Expand Messages | Collapse Messages