[Android] Include NestedSystemMessageHandler in gn builds of content_shell_apk.

[Android] Include NestedSystemMessageHandler in gn builds of content_shell_apk.

content_shell_apk uses NestedSystemMessageHandler when running layout tests,
and gyp builds of content_shell_apk depend on content_java_test_support for
this reason. This CL splits a more narrow "layouttest_java_support" gn target
from content_java_test_support containing only NestedSystemMessageHandler and
makes content_shell_apk depend on it. It also marks content_java_test_support
and dependent targets testonly.

BUG=604468
Committed: https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb
Cr-Commit-Position: refs/heads/master@{#390093}

[jbudorick, 2016-04-26 13:40:44]

jbudorick@chromium.org changed reviewers:
+ agrieve@chromium.org, boliu@chromium.org, jochen@chromium.org,
sievers@chromium.org

[jbudorick, 2016-04-26 13:40:44]

ContentShell uses NestedSystemMessageHandler when running layout tests. This is
why content_shell_apk in gyp depends on content_java_test_support:
https://code.google.com/p/chromium/codesearch#chromium/src/content/content_sh...

ptal:
 agrieve: review
 boliu: android_webview/ owners
 jochen: components/ owners
 sievers: content/ owners

[boliu, 2016-04-26 14:10:48]

lgtm

[boliu, 2016-04-26 14:13:39]

I am going to complain about CL description that doesn't give any details
though..

[jbudorick, 2016-04-26 14:15:11]

On 2016/04/26 14:13:39, boliu wrote:
> I am going to complain about CL description that doesn't give any details
> though..

Moving the description from https://codereview.chromium.org/1921223003/#msg2 up
to the CL description.

[jbudorick, 2016-04-26 14:18:45]

Description was changed from

==========
[Android] Include NestedSystemMessageHandler in gn builds of content_shell_apk.

BUG=604468
==========

to

==========
[Android] Include NestedSystemMessageHandler in gn builds of content_shell_apk.

content_shell_apk uses NestedSystemMessageHandler when running layout tests,
and gyp builds of content_shell_apk depend on content_java_test_support for
this reason. This CL splits a more narrow "layouttest_java_support" gn target
from content_java_test_support containing only NestedSystemMessageHandler and
makes content_shell_apk depend on it. It also marks content_java_test_support
and dependent targets testonly.

BUG=604468
==========

[jbudorick, 2016-04-26 14:19:02]

On 2016/04/26 14:15:11, jbudorick wrote:
> On 2016/04/26 14:13:39, boliu wrote:
> > I am going to complain about CL description that doesn't give any details
> > though..
> 
> Moving the description from https://codereview.chromium.org/1921223003/#msg2
up
> to the CL description.

(updated)

[agrieve, 2016-04-26 14:31:35]

lgtm

https://codereview.chromium.org/1921223003/diff/1/content/public/test/android...
File content/public/test/android/BUILD.gn (right):

https://codereview.chromium.org/1921223003/diff/1/content/public/test/android...
content/public/test/android/BUILD.gn:13: deps = [
testonly?

[jbudorick, 2016-04-26 14:33:05]

https://codereview.chromium.org/1921223003/diff/1/content/public/test/android...
File content/public/test/android/BUILD.gn (right):

https://codereview.chromium.org/1921223003/diff/1/content/public/test/android...
content/public/test/android/BUILD.gn:13: deps = [
On 2016/04/26 14:31:34, agrieve wrote:
> testonly?

I guess it could be. I intentionally left it off because I assumed that
content_shell_apk isn't testonly, but it is.

[no sievers, 2016-04-26 19:15:02]

Does content_shell really need the dependency or just content_browsertests?

[jbudorick, 2016-04-26 19:16:18]

On 2016/04/26 19:15:02, sievers wrote:
> Does content_shell really need the dependency or just content_browsertests?

content_shell needs the dependency. blink_tests uses content_shell and expects
this to be there. (I'm not sure if content_browsertests needs this or not.)

[jbudorick, 2016-04-26 19:20:35]

On 2016/04/26 19:16:18, jbudorick wrote:
> On 2016/04/26 19:15:02, sievers wrote:
> > Does content_shell really need the dependency or just content_browsertests?
> 
> content_shell needs the dependency. blink_tests uses content_shell and expects
> this to be there. (I'm not sure if content_browsertests needs this or not.)

specifically:

content::ShellMainDelegate::RunProcess -> ::LayoutTestBrowserMain ->
content::EnsureInitializeForAndroidLayoutTests ->
content::NestedMessagePumpAndroid -> NestedSystemMessageHandler

[no sievers, 2016-04-26 19:27:10]

On 2016/04/26 19:20:35, jbudorick wrote:
> On 2016/04/26 19:16:18, jbudorick wrote:
> > On 2016/04/26 19:15:02, sievers wrote:
> > > Does content_shell really need the dependency or just
content_browsertests?
> > 
> > content_shell needs the dependency. blink_tests uses content_shell and
expects
> > this to be there. (I'm not sure if content_browsertests needs this or not.)
> 
> specifically:
> 
> content::ShellMainDelegate::RunProcess -> ::LayoutTestBrowserMain ->
> content::EnsureInitializeForAndroidLayoutTests ->
> content::NestedMessagePumpAndroid -> NestedSystemMessageHandler

The nested pump is needed whenever we run a nested msg loop in tests but also
need to dispatch messages to the system (such as to the Views).
content_browsertests definitely needs it, but I guess potentially any tests that
embed the ContentShell and run nested loops.

Either way, LGTM.

[jochen (gone - plz use gerrit), 2016-04-27 12:07:37]

rubberstamp lgtm

[jbudorick, 2016-04-27 15:23:42]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-04-27 15:23:43]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
agrieve@chromium.org, jochen@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1921223003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-27 15:24:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921223003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921223003/40001

[commit-bot: I haz the power, 2016-04-27 16:15:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:10:20]

Patchset 3 (id:??) landed as
https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb
Cr-Commit-Position: refs/heads/master@{#390093}

[commit-bot: I haz the power, 2016-04-30 17:50:16]

Description was changed from

==========
[Android] Include NestedSystemMessageHandler in gn builds of content_shell_apk.

content_shell_apk uses NestedSystemMessageHandler when running layout tests,
and gyp builds of content_shell_apk depend on content_java_test_support for
this reason. This CL splits a more narrow "layouttest_java_support" gn target
from content_java_test_support containing only NestedSystemMessageHandler and
makes content_shell_apk depend on it. It also marks content_java_test_support
and dependent targets testonly.

BUG=604468
==========

to

==========
[Android] Include NestedSystemMessageHandler in gn builds of content_shell_apk.

content_shell_apk uses NestedSystemMessageHandler when running layout tests,
and gyp builds of content_shell_apk depend on content_java_test_support for
this reason. This CL splits a more narrow "layouttest_java_support" gn target
from content_java_test_support containing only NestedSystemMessageHandler and
makes content_shell_apk depend on it. It also marks content_java_test_support
and dependent targets testonly.

BUG=604468

Committed: https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb
Cr-Commit-Position: refs/heads/master@{#390093}
==========