Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/arm64/assembler-arm64-inl.h

Issue 1921203002: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory … (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add compiler test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_ 5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_
6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_ 6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_
7 7
8 #include "src/arm64/assembler-arm64.h" 8 #include "src/arm64/assembler-arm64.h"
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 24 matching lines...) Expand all
35 icache_flush_mode); 35 icache_flush_mode);
36 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL && 36 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL &&
37 IsCodeTarget(rmode_)) { 37 IsCodeTarget(rmode_)) {
38 Object* target_code = Code::GetCodeFromTargetAddress(target); 38 Object* target_code = Code::GetCodeFromTargetAddress(target);
39 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode( 39 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
40 host(), this, HeapObject::cast(target_code)); 40 host(), this, HeapObject::cast(target_code));
41 } 41 }
42 } 42 }
43 43
44 void RelocInfo::update_wasm_memory_reference( 44 void RelocInfo::update_wasm_memory_reference(
45 Address old_base, Address new_base, size_t old_size, size_t new_size, 45 Address old_base, Address new_base, int32_t old_size, int32_t new_size,
46 ICacheFlushMode icache_flush_mode) { 46 ICacheFlushMode icache_flush_mode) {
47 DCHECK(IsWasmMemoryReference(rmode_)); 47 DCHECK(IsWasmMemoryReference(rmode_) || IsWasmMemorySizeReference(rmode_));
48 DCHECK(old_base <= wasm_memory_reference() && 48 if (IsWasmMemoryReference(rmode_) && old_base != new_base) {
49 wasm_memory_reference() < old_base + old_size); 49 Address updated_memory_reference;
50 Address updated_reference = new_base + (wasm_memory_reference() - old_base); 50 DCHECK(old_base <= wasm_memory_reference() &&
51 DCHECK(new_base <= updated_reference && 51 wasm_memory_reference() < old_base + old_size);
52 updated_reference < new_base + new_size); 52 updated_memory_reference = new_base + (wasm_memory_reference() - old_base);
53 Assembler::set_target_address_at(isolate_, pc_, host_, updated_reference, 53 DCHECK(new_base <= updated_memory_reference &&
54 icache_flush_mode); 54 updated_memory_reference < new_base + new_size);
55 Assembler::set_target_address_at(
56 isolate_, pc_, host_, updated_memory_reference, icache_flush_mode);
57 } else if (IsWasmMemorySizeReference(rmode_)) {
58 int32_t updated_size_reference;
59 DCHECK(wasm_memory_size_reference() <= old_size);
60 updated_size_reference =
61 new_size + (wasm_memory_size_reference() - old_size);
62 DCHECK(updated_size_reference <= new_size);
63 Memory::int32_at(Assembler::target_pointer_address_at(pc_)) =
64 updated_size_reference;
65 } else {
66 UNREACHABLE();
67 }
55 } 68 }
56 69
57 inline int CPURegister::code() const { 70 inline int CPURegister::code() const {
58 DCHECK(IsValid()); 71 DCHECK(IsValid());
59 return reg_code; 72 return reg_code;
60 } 73 }
61 74
62 75
63 inline CPURegister::RegisterType CPURegister::type() const { 76 inline CPURegister::RegisterType CPURegister::type() const {
64 DCHECK(IsValidOrNone()); 77 DCHECK(IsValidOrNone());
(...skipping 635 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 } 713 }
701 714
702 715
703 Address RelocInfo::target_address() { 716 Address RelocInfo::target_address() {
704 DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)); 717 DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
705 return Assembler::target_address_at(pc_, host_); 718 return Assembler::target_address_at(pc_, host_);
706 } 719 }
707 720
708 Address RelocInfo::wasm_memory_reference() { 721 Address RelocInfo::wasm_memory_reference() {
709 DCHECK(IsWasmMemoryReference(rmode_)); 722 DCHECK(IsWasmMemoryReference(rmode_));
710 return Assembler::target_address_at(pc_, host_); 723 return Memory::Address_at(Assembler::target_pointer_address_at(pc_));
724 }
725
726 int32_t RelocInfo::wasm_memory_size_reference() {
727 DCHECK(IsWasmMemorySizeReference(rmode_));
728 return Memory::int32_at(Assembler::target_pointer_address_at(pc_));
711 } 729 }
712 730
713 Address RelocInfo::target_address_address() { 731 Address RelocInfo::target_address_address() {
714 DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_) 732 DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_)
715 || rmode_ == EMBEDDED_OBJECT 733 || rmode_ == EMBEDDED_OBJECT
716 || rmode_ == EXTERNAL_REFERENCE); 734 || rmode_ == EXTERNAL_REFERENCE);
717 return Assembler::target_pointer_address_at(pc_); 735 return Assembler::target_pointer_address_at(pc_);
718 } 736 }
719 737
720 738
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
1254 1272
1255 void Assembler::ClearRecordedAstId() { 1273 void Assembler::ClearRecordedAstId() {
1256 recorded_ast_id_ = TypeFeedbackId::None(); 1274 recorded_ast_id_ = TypeFeedbackId::None();
1257 } 1275 }
1258 1276
1259 1277
1260 } // namespace internal 1278 } // namespace internal
1261 } // namespace v8 1279 } // namespace v8
1262 1280
1263 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_ 1281 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698