Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: services/catalog/reader.h

Issue 1921183003: Fixes race in Shell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge 2 trunk Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/catalog/catalog.cc ('k') | services/catalog/reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/catalog/reader.h
diff --git a/services/catalog/reader.h b/services/catalog/reader.h
index 322057bbd74ff25f5b7696bbf96c024ec49f6160..1e6224bad69047a0849b771e05405f4a7d3f07c8 100644
--- a/services/catalog/reader.h
+++ b/services/catalog/reader.h
@@ -15,7 +15,8 @@
#include "services/shell/public/interfaces/shell_resolver.mojom.h"
namespace base {
-class TaskRunner;
+class SequencedWorkerPool;
+class SingleThreadTaskRunner;
}
namespace catalog {
@@ -30,7 +31,9 @@ class Reader {
using CreateEntryForNameCallback =
base::Callback<void(shell::mojom::ResolveResultPtr)>;
- Reader(base::TaskRunner* file_task_runner,
+ Reader(base::SequencedWorkerPool* worker_pool,
+ ManifestProvider* manifest_provider);
+ Reader(base::SingleThreadTaskRunner* task_runner,
ManifestProvider* manifest_provider);
~Reader();
@@ -48,12 +51,14 @@ class Reader {
const CreateEntryForNameCallback& entry_created_callback);
private:
+ explicit Reader(ManifestProvider* manifest_provider);
+
void OnReadManifest(EntryCache* cache,
const CreateEntryForNameCallback& entry_created_callback,
std::unique_ptr<Entry> entry);
base::FilePath system_package_dir_;
- base::TaskRunner* file_task_runner_;
+ scoped_refptr<base::TaskRunner> file_task_runner_;
ManifestProvider* const manifest_provider_;
base::WeakPtrFactory<Reader> weak_factory_;
« no previous file with comments | « services/catalog/catalog.cc ('k') | services/catalog/reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698