Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1921173003: pathops: Cosmetic only change, update comments around ComplexBreak(). (Closed)

Created:
4 years, 8 months ago by Dean McNamee
Modified:
4 years, 8 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git/@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

pathops: Cosmetic only change, update comments around ComplexBreak(). Rename loopT to splitT and make it clearer that it is not just self intersecting loop cubics that are split. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921173003 Committed: https://skia.googlesource.com/skia/+/b77821c30cd07507447244271eedf4e7c615e35a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/pathops/SkOpEdgeBuilder.cpp View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Dean McNamee
4 years, 8 months ago (2016-04-26 16:27:57 UTC) #4
caryclark
lgtm
4 years, 8 months ago (2016-04-26 16:29:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921173003/1
4 years, 8 months ago (2016-04-26 17:12:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/8112) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
4 years, 8 months ago (2016-04-26 17:13:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921173003/1
4 years, 8 months ago (2016-04-26 20:12:34 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:12:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b77821c30cd07507447244271eedf4e7c615e35a

Powered by Google App Engine
This is Rietveld 408576698