Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3627)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 1921153002: Fix crash in extension installed bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index ded5a144902386b2b05f4b673d19f81fd89d9efe..e30a98ac73298dc096206bc0fb6a30995024de3e 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -269,13 +269,13 @@ void ExtensionInstalledBubbleView::ButtonPressed(views::Button* sender,
void ExtensionInstalledBubbleView::LinkClicked(views::Link* source,
int event_flags) {
DCHECK_EQ(manage_shortcut_, source);
- CloseBubble();
std::string configure_url = chrome::kChromeUIExtensionsURL;
configure_url += chrome::kExtensionConfigureCommandsSubPage;
chrome::NavigateParams params(
chrome::GetSingletonTabNavigateParams(browser(), GURL(configure_url)));
chrome::Navigate(&params);
+ CloseBubble();
}
void ExtensionInstalledBubbleView::Init() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698