Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921153002: Fix crash in extension installed bubble. (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in extension installed bubble. BUG=606251 Committed: https://crrev.com/dc0b4da600b1b35903411b5c909bb1aed135e3e9 Cr-Commit-Position: refs/heads/master@{#389654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
pretty straightforward fix. Didn't bother to investigate why this wasn't a problem before my change, ...
4 years, 8 months ago (2016-04-26 00:19:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921153002/1
4 years, 8 months ago (2016-04-26 00:20:12 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 01:07:31 UTC) #6
msw
lgtm
4 years, 8 months ago (2016-04-26 01:17:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921153002/1
4 years, 8 months ago (2016-04-26 01:19:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 01:27:23 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 01:29:08 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc0b4da600b1b35903411b5c909bb1aed135e3e9
Cr-Commit-Position: refs/heads/master@{#389654}

Powered by Google App Engine
This is Rietveld 408576698