Adds ash::MaterialDesignController

ash/test/material_design_controller_test_api.cc

-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ui/base/test/material_design_controller_test_api.h"
+#include "ash/test/material_design_controller_test_api.h"
 
-namespace ui {
+namespace ash {
 namespace test {
 
-MaterialDesignControllerTestAPI::MaterialDesignControllerTestAPI(
-    MaterialDesignController::Mode mode)
+MaterialDesignControllerTestAPI::MaterialDesignControllerTestAPI(bool mode)
     : previous_mode_(MaterialDesignController::mode_),
       previous_initialized_(MaterialDesignController::is_mode_initialized_) {
   MaterialDesignController::SetMode(mode);
 }
 
 MaterialDesignControllerTestAPI::~MaterialDesignControllerTestAPI() {
   MaterialDesignController::is_mode_initialized_ = previous_initialized_;
   MaterialDesignController::mode_ = previous_mode_;

[oshima, 2016/04/26 16:06:58]

Are you going to allow a test to change mode in the middle?
It can allow two UI mode mixed, which may results in unexpected results.

[varkha, 2016/04/27 21:00:09]

This can be used by tests that want to set and restore mode, e.g. when a test
wants to test with multiple flag values. There are tests like that for
ui::base::MaterialDesignController (the top-chrome variant) but not yet for this
ash variant.

[oshima, 2016/04/27 21:51:04]

Since the flag will never change during runtime, I'd usually recommend to
separate such test into multiple tests,
but I don't have strong opinion, so you may keep it if you prefer.

[varkha, 2016/04/27 22:14:00]

This is more for having pre-existing tests that we would want to run with or
without MD flags to make sure both cases are not broken.

[varkha, 2016/04/27 22:20:07]

e.g. here -
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/animation...

 }
 
+// static
+bool MaterialDesignControllerTestAPI::DefaultMode() {
+  return MaterialDesignController::DefaultMode();
+}
+
+// static
 void MaterialDesignControllerTestAPI::Uninitialize() {
   MaterialDesignController::Uninitialize();
 }
 
 }  // namespace test
-}  // namespace ui
+}  // namespace ash