mash: Add a test for exe:chrome.

mash: Add a test for exe:chrome.

Tests that chrome launches correctly in mus and produces at least
one valid compositor frame to mus.

BUG=581733

[sadrul, 2016-04-25 22:17:01]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-04-25 23:37:45]

https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn
File mash/wm/BUILD.gn (right):

https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn#newcod...
mash/wm/BUILD.gn:174: "//chrome",
I would like to avoid the all target building chrome. Can we have the test exist
in the chrome side?

[sky, 2016-04-25 23:38:09]

On 2016/04/25 23:37:45, sky wrote:
> https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn
> File mash/wm/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn#newcod...
> mash/wm/BUILD.gn:174: "//chrome",
> I would like to avoid the all target building chrome. Can we have the test
exist
> in the chrome side?

An alternative is to have a separate all target all_chrome.

[sadrul, 2016-04-26 19:31:58]

On 2016/04/25 23:38:09, sky wrote:
> On 2016/04/25 23:37:45, sky wrote:
> > https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn
> > File mash/wm/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn#newcod...
> > mash/wm/BUILD.gn:174: "//chrome",
> > I would like to avoid the all target building chrome. Can we have the test
> exist
> > in the chrome side?
> 
> An alternative is to have a separate all target all_chrome.

To clarify, that means mash_unittests should move out of mash:all, and instead
go in mash:all_chrome (which includes mash:all and mash_unittests)?

[sky, 2016-04-26 21:11:03]

How about adding the unittest to chrome's unittests?

On Tue, Apr 26, 2016 at 12:31 PM,  <sadrul@chromium.org> wrote:
> On 2016/04/25 23:38:09, sky wrote:
>> On 2016/04/25 23:37:45, sky wrote:
>> > https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn
>> > File mash/wm/BUILD.gn (right):
>> >
>> >
>>
>
https://codereview.chromium.org/1921113002/diff/20001/mash/wm/BUILD.gn#newcod...
>> > mash/wm/BUILD.gn:174: "//chrome",
>> > I would like to avoid the all target building chrome. Can we have the
>> > test
>> exist
>> > in the chrome side?
>>
>> An alternative is to have a separate all target all_chrome.
>
> To clarify, that means mash_unittests should move out of mash:all, and
> instead
> go in mash:all_chrome (which includes mash:all and mash_unittests)?
>
> https://codereview.chromium.org/1921113002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.