Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1921093002: Remove abortWebLoad from CRWWebController. (Closed)

Created:
4 years, 8 months ago by michaeldo
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove abortWebLoad from CRWWebController. TEST=Navigate to chrome://chrome-urls, then navigate to one of the other chrome:// pages using the displayed links. BUG=579697 Committed: https://crrev.com/a0f8b0117b0b2c36b0072eec5df321e57d40f05f Cr-Commit-Position: refs/heads/master@{#389809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
michaeldo
4 years, 8 months ago (2016-04-25 21:27:38 UTC) #2
Eugene But (OOO till 7-30)
lgtm, please wait for Jackie to sign off on WebUI changes.
4 years, 8 months ago (2016-04-25 21:44:26 UTC) #4
Jackie Quinn
lgtm
4 years, 8 months ago (2016-04-26 15:49:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921093002/1
4 years, 8 months ago (2016-04-26 16:03:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 16:56:56 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 16:58:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0f8b0117b0b2c36b0072eec5df321e57d40f05f
Cr-Commit-Position: refs/heads/master@{#389809}

Powered by Google App Engine
This is Rietveld 408576698