Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921083002: [es6] Fix tail call elimination in single-expression arrow functions. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix tail call elimination in single-expression arrow functions. BUG=v8:4698 LOG=Y Committed: https://crrev.com/086fe2199ba7849113413a21ceb38d167eb74176 Cr-Commit-Position: refs/heads/master@{#35786}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M src/parsing/parser.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/parsing/parser-base.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921083002/1
4 years, 8 months ago (2016-04-25 20:58:12 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 21:35:46 UTC) #4
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-25 21:37:35 UTC) #6
rossberg
lgtm https://codereview.chromium.org/1921083002/diff/1/src/parsing/parser.h File src/parsing/parser.h (right): https://codereview.chromium.org/1921083002/diff/1/src/parsing/parser.h#newcode575 src/parsing/parser.h:575: V8_INLINE void MarkExpressionInTailPosition(Expression* expression); Nit: just MarkTailPosition?
4 years, 8 months ago (2016-04-26 07:42:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921083002/20001
4 years, 8 months ago (2016-04-26 08:42:28 UTC) #10
Igor Sheludko
https://codereview.chromium.org/1921083002/diff/1/src/parsing/parser.h File src/parsing/parser.h (right): https://codereview.chromium.org/1921083002/diff/1/src/parsing/parser.h#newcode575 src/parsing/parser.h:575: V8_INLINE void MarkExpressionInTailPosition(Expression* expression); On 2016/04/26 07:42:31, rossberg wrote: ...
4 years, 8 months ago (2016-04-26 08:42:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 09:05:53 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 09:07:56 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/086fe2199ba7849113413a21ceb38d167eb74176
Cr-Commit-Position: refs/heads/master@{#35786}

Powered by Google App Engine
This is Rietveld 408576698