Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921073004: [Bindings] Remove an unused parameter (Closed)

Created:
4 years, 8 months ago by peria
Modified:
4 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unused parameter This CL is to remove an unused parameter, which is no longer used after http://crrev.com/1760143003 BUG=591897 Committed: https://crrev.com/20a0a11fe2e76e22a99c21362c92ec3e36507f07 Cr-Commit-Position: refs/heads/master@{#390025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
peria
PTL just a refactoring CL.
4 years, 8 months ago (2016-04-27 07:25:09 UTC) #3
Yuki
lgtm
4 years, 8 months ago (2016-04-27 07:28:26 UTC) #4
haraken
LGTM
4 years, 8 months ago (2016-04-27 07:31:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921073004/1
4 years, 8 months ago (2016-04-27 07:32:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-27 08:49:10 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-27 08:50:24 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/20a0a11fe2e76e22a99c21362c92ec3e36507f07
Cr-Commit-Position: refs/heads/master@{#390025}

Powered by Google App Engine
This is Rietveld 408576698