Add partial viewport visibility check to autoplay experiment.

Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG=605609
Committed: https://crrev.com/fafc5a0d288d30ad051e9269d6bdac1f79ed2f5b
Cr-Commit-Position: refs/heads/master@{#389802}

[liberato (no reviews please), 2016-04-25 20:48:14]

Description was changed from

==========
Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG=605609
==========

to

==========
Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG=605609
==========

[liberato (no reviews please), 2016-04-25 20:48:16]

liberato@chromium.org changed reviewers:
+ mlamouri@chromium.org, philipj@opera.com

[mlamouri (slow - plz ping), 2016-04-26 14:04:21]

Instead of adding yet another flag, can we simply change -ifviewport to accept
partial viewport? I'm afraid we might be increasing the complexity for very
little benefit.

[liberato (no reviews please), 2016-04-26 14:32:30]

On 2016/04/26 14:04:21, Mounir Lamouri wrote:
> Instead of adding yet another flag, can we simply change -ifviewport to accept
> partial viewport? I'm afraid we might be increasing the complexity for very
> little benefit.

i'd prefer not to do that, since it keeps the interpretation of the collected
data the same across versions.  i can remove the old one, i suppose, if it's a
big concern.

however, there was some discussion about how exactly we should define "visible".
 i think that there's still some value in being able to try the other
definition, with everything else held constant.  i wouldn't care enough to add
it now if it weren't already there, but it is.

[philipj_slow, 2016-04-26 14:35:49]

philipj@opera.com changed reviewers:
- philipj@opera.com

[philipj_slow, 2016-04-26 14:35:50]

This is my last week at Opera, so I can't take on any new reviews now, sorry.

[mlamouri (slow - plz ping), 2016-04-26 14:45:38]

lgtm

Ok.

[liberato (no reviews please), 2016-04-26 15:24:59]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2016-04-26 15:25:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921073002/1

[commit-bot: I haz the power, 2016-04-26 16:27:58]

Description was changed from

==========
Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG=605609
==========

to

==========
Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG=605609
==========

[commit-bot: I haz the power, 2016-04-26 16:27:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 16:29:02]

Description was changed from

==========
Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG=605609
==========

to

==========
Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG=605609

Committed: https://crrev.com/fafc5a0d288d30ad051e9269d6bdac1f79ed2f5b
Cr-Commit-Position: refs/heads/master@{#389802}
==========

[commit-bot: I haz the power, 2016-04-26 16:29:03]

Patchset 1 (id:??) landed as
https://crrev.com/fafc5a0d288d30ad051e9269d6bdac1f79ed2f5b
Cr-Commit-Position: refs/heads/master@{#389802}