Issue 192103002: Drop SVGElement::isGradientStop() virtual function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192103002: Drop SVGElement::isGradientStop() virtual function (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
pdr., Stephen Chennney

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Drop SVGElement::isGradientStop() virtual function Drop SVGElement::isGradientStop() virtual function and use the isSVGStopElement() helper function instead, for consistency. Unless I am missing something, we don't need a virtual function here and checking for the SVGNames::stopTag should be sufficient. R=pdr BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168795

Patch Set 1 #

Patch Set 2 : Use Traversal<> API #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
M	Source/core/svg/SVGElement.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGGradientElement.cpp	View	1	1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/core/svg/SVGStopElement.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/192103002/20001

6 years, 9 months ago (2014-03-09 00:15:22 UTC) #4

Message was sent while issue was closed.

Change committed as 168795

Expand Messages | Collapse Messages