[Autofill] Update expired verified credit cards.

Update the expiration date of an expired credit card if the card number is the same and the name on the cards are an exact match.

BUG=606821
TEST=CreditCardTest

Committed: https://crrev.com/9af0021f08859cc6c3a3694087ddae4a7e1fbd3a
Cr-Commit-Position: refs/heads/master@{#389905}

[sebsg, 2016-04-26 17:04:38]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-04-26 17:10:46]

Description was changed from

==========
[Autofill] Update expired verified credit cards.
==========

to

==========
Update the expiration date of an expired credit card if the card number is the
same and the name on the cards are an exact match.

BUG=606821
TEST=CreditCardTest
==========

[sebsg, 2016-04-26 17:10:46]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2016-04-26 18:12:55]

Patchset #1 (id:20001) has been deleted

[sebsg, 2016-04-26 18:17:16]

Patchset #1 (id:40001) has been deleted

[sebsg, 2016-04-26 18:17:46]

Hey Math could you please take a look?

[Mathieu, 2016-04-26 20:06:19]

lgtm with a note :)

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card.cc:537: // Heuristically aggregated
data should never overwrite verified data.
update comment

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card_unittest.cc (right):

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card_unittest.cc:351: // |a| should be
updated with |b|'s expiration date and keep it's original
*its

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card_unittest.cc:366:
a.set_origin("Chrome settings");
in autofill_test_utils.h and .cc, let's expose kSettingsOrigin and use it
everywhere in this file as test::kSettingsOrigin.

(Can do it in a separate CL because it would benefit a lot of _unittest files)

[sebsg, 2016-04-26 21:06:14]

Thanks, will send to CQ.

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card.cc:537: // Heuristically aggregated
data should never overwrite verified data.
On 2016/04/26 20:06:19, Mathieu Perreault wrote:
> update comment

Done.

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
File components/autofill/core/browser/credit_card_unittest.cc (right):

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card_unittest.cc:351: // |a| should be
updated with |b|'s expiration date and keep it's original
On 2016/04/26 20:06:19, Mathieu Perreault wrote:
> *its

Done.

https://codereview.chromium.org/1921003003/diff/60001/components/autofill/cor...
components/autofill/core/browser/credit_card_unittest.cc:366:
a.set_origin("Chrome settings");
On 2016/04/26 20:06:19, Mathieu Perreault wrote:
> in autofill_test_utils.h and .cc, let's expose kSettingsOrigin and use it
> everywhere in this file as test::kSettingsOrigin.
> 
> (Can do it in a separate CL because it would benefit a lot of _unittest files)

Acknowledged.

[sebsg, 2016-04-26 21:06:18]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-04-26 21:06:18]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1921003003/#ps80001
(title: "Nits")

[commit-bot: I haz the power, 2016-04-26 21:06:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921003003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921003003/80001

[commit-bot: I haz the power, 2016-04-26 21:56:18]

Description was changed from

==========
Update the expiration date of an expired credit card if the card number is the
same and the name on the cards are an exact match.

BUG=606821
TEST=CreditCardTest
==========

to

==========
Update the expiration date of an expired credit card if the card number is the
same and the name on the cards are an exact match.

BUG=606821
TEST=CreditCardTest
==========

[commit-bot: I haz the power, 2016-04-26 21:56:19]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-04-26 21:57:31]

Description was changed from

==========
Update the expiration date of an expired credit card if the card number is the
same and the name on the cards are an exact match.

BUG=606821
TEST=CreditCardTest
==========

to

==========
Update the expiration date of an expired credit card if the card number is the
same and the name on the cards are an exact match.

BUG=606821
TEST=CreditCardTest

Committed: https://crrev.com/9af0021f08859cc6c3a3694087ddae4a7e1fbd3a
Cr-Commit-Position: refs/heads/master@{#389905}
==========

[commit-bot: I haz the power, 2016-04-26 21:57:32]

Patchset 2 (id:??) landed as
https://crrev.com/9af0021f08859cc6c3a3694087ddae4a7e1fbd3a
Cr-Commit-Position: refs/heads/master@{#389905}