Issue 19210002: Throw if first argument to TypedArray.set is a number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19210002: Throw if first argument to TypedArray.set is a number. (Closed)

Created:
7 years, 5 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 5 months ago

Reviewers:
Benedikt Meurer, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Throw if first argument to TypedArray.set is a number. Further refinement to semantics that I have missed in previous change. Both Blink and Firefox are permissive with arguments to .set method. However, when first argument to "set" is a number, all implementations throw, so that users know that a.set(0,27) does not assign 27 to 0th element of a, not 0 to 27th element of a. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15684

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -4 lines)			Patch
M	src/typedarray.js	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	test/mjsunit/external-array.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/external-array-no-sse2.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/typedarrays.js	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

LGTM with comment https://codereview.chromium.org/19210002/diff/1/src/typedarray.js File src/typedarray.js (right): https://codereview.chromium.org/19210002/diff/1/src/typedarray.js#newcode157 src/typedarray.js:157: if (IS_NUMBER(obj)) This if is missing ...

7 years, 5 months ago (2013-07-16 05:39:56 UTC) #2

Dmitry Lomov (no reviews)

7 years, 5 months ago (2013-07-16 08:11:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15684 (presubmit successful).

Expand Messages | Collapse Messages