Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1920953002: Revert of [css-grid] Implement auto-repeat computation (Closed)

Created:
4 years, 7 months ago by Charlie Reis
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of https://codereview.chromium.org/1895443002/ ) Reason for revert: Appeared to cause lots of fast/css-grid-layout test failures on WebKit Linux MSAN: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/9688 Original issue's description: > [css-grid] Implement auto-repeat computation > > We added support for parsing and style for the new auto-repeat syntax. This > CL actually implements the feature by computing the number of auto-repeat > tracks that will be part of the explicit grid depending on the available > size on the corresponding axis. > > Note that this CL does not drop the empty tracks, i.e., auto-fit will work > exactly as auto-fill until the empty track removal is implemented. > > Test results are not totally correct yet because we need to add the line > names to the computed style. As that requires a rather large piece of code > it will be done in a follow up patch. Track sizes are correct though. > > BUG=589460 > > Committed: https://crrev.com/7b1b0f17c7a1eac0283fc9daa519328a42e0139f > Cr-Commit-Position: refs/heads/master@{#389456} TBR=cbiesinger@chromium.org,timloh@chromium.org,rune@opera.com,rego@igalia.com,svillar@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589460 Committed: https://crrev.com/9307c20948380712fc0abfe53a01844e2e103fbc Cr-Commit-Position: refs/heads/master@{#389504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2860 lines) Patch
D third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-columns.html View 1 chunk +0 lines, -144 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html View 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-change-auto-repeat-tracks.html View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-change-auto-repeat-tracks-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set.html View 1 chunk +8 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt View 1 chunk +24 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001.html View 1 chunk +0 lines, -179 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001-expected.html View 1 chunk +0 lines, -193 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-002.html View 1 chunk +0 lines, -183 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-002-expected.html View 1 chunk +0 lines, -190 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-003.html View 1 chunk +0 lines, -182 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-003-expected.html View 1 chunk +0 lines, -191 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-004.html View 1 chunk +0 lines, -184 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-004-expected.html View 1 chunk +0 lines, -193 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-005.html View 1 chunk +0 lines, -378 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-005-expected.html View 1 chunk +0 lines, -384 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 4 chunks +11 lines, -110 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Charlie Reis
Created Revert of [css-grid] Implement auto-repeat computation
4 years, 7 months ago (2016-04-25 16:49:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920953002/1
4 years, 7 months ago (2016-04-25 16:49:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-25 16:51:01 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-25 16:52:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9307c20948380712fc0abfe53a01844e2e103fbc
Cr-Commit-Position: refs/heads/master@{#389504}

Powered by Google App Engine
This is Rietveld 408576698