Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of https://codereview.chromium.org/1895443002/ )
Reason for revert:
Appeared to cause lots of fast/css-grid-layout test failures on WebKit Linux MSAN:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/9688
Original issue's description:
> [css-grid] Implement auto-repeat computation
>
> We added support for parsing and style for the new auto-repeat syntax. This
> CL actually implements the feature by computing the number of auto-repeat
> tracks that will be part of the explicit grid depending on the available
> size on the corresponding axis.
>
> Note that this CL does not drop the empty tracks, i.e., auto-fit will work
> exactly as auto-fill until the empty track removal is implemented.
>
> Test results are not totally correct yet because we need to add the line
> names to the computed style. As that requires a rather large piece of code
> it will be done in a follow up patch. Track sizes are correct though.
>
> BUG=589460
>
> Committed: https://crrev.com/7b1b0f17c7a1eac0283fc9daa519328a42e0139f
> Cr-Commit-Position: refs/heads/master@{#389456}
TBR=cbiesinger@chromium.org,timloh@chromium.org,rune@opera.com,rego@igalia.com,svillar@igalia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589460
Committed: https://crrev.com/9307c20948380712fc0abfe53a01844e2e103fbc
Cr-Commit-Position: refs/heads/master@{#389504}
Created Revert of [css-grid] Implement auto-repeat computation
4 years, 7 months ago
(2016-04-25 16:49:25 UTC)
#1
Created Revert of [css-grid] Implement auto-repeat computation
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920953002/1
4 years, 7 months ago
(2016-04-25 16:49:52 UTC)
#2
Description was changed from ========== Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of ...
4 years, 7 months ago
(2016-04-25 16:50:59 UTC)
#3
Message was sent while issue was closed.
Description was changed from
==========
Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of
https://codereview.chromium.org/1895443002/ )
Reason for revert:
Appeared to cause lots of fast/css-grid-layout test failures on WebKit Linux
MSAN:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Original issue's description:
> [css-grid] Implement auto-repeat computation
>
> We added support for parsing and style for the new auto-repeat syntax. This
> CL actually implements the feature by computing the number of auto-repeat
> tracks that will be part of the explicit grid depending on the available
> size on the corresponding axis.
>
> Note that this CL does not drop the empty tracks, i.e., auto-fit will work
> exactly as auto-fill until the empty track removal is implemented.
>
> Test results are not totally correct yet because we need to add the line
> names to the computed style. As that requires a rather large piece of code
> it will be done in a follow up patch. Track sizes are correct though.
>
> BUG=589460
>
> Committed: https://crrev.com/7b1b0f17c7a1eac0283fc9daa519328a42e0139f
> Cr-Commit-Position: refs/heads/master@{#389456}
TBR=cbiesinger@chromium.org,timloh@chromium.org,rune@opera.com,rego@igalia.co...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589460
==========
to
==========
Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of
https://codereview.chromium.org/1895443002/ )
Reason for revert:
Appeared to cause lots of fast/css-grid-layout test failures on WebKit Linux
MSAN:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Original issue's description:
> [css-grid] Implement auto-repeat computation
>
> We added support for parsing and style for the new auto-repeat syntax. This
> CL actually implements the feature by computing the number of auto-repeat
> tracks that will be part of the explicit grid depending on the available
> size on the corresponding axis.
>
> Note that this CL does not drop the empty tracks, i.e., auto-fit will work
> exactly as auto-fill until the empty track removal is implemented.
>
> Test results are not totally correct yet because we need to add the line
> names to the computed style. As that requires a rather large piece of code
> it will be done in a follow up patch. Track sizes are correct though.
>
> BUG=589460
>
> Committed: https://crrev.com/7b1b0f17c7a1eac0283fc9daa519328a42e0139f
> Cr-Commit-Position: refs/heads/master@{#389456}
TBR=cbiesinger@chromium.org,timloh@chromium.org,rune@opera.com,rego@igalia.co...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589460
==========
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago
(2016-04-25 16:51:01 UTC)
#4
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of ...
4 years, 7 months ago
(2016-04-25 16:52:53 UTC)
#5
Message was sent while issue was closed.
Description was changed from
==========
Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of
https://codereview.chromium.org/1895443002/ )
Reason for revert:
Appeared to cause lots of fast/css-grid-layout test failures on WebKit Linux
MSAN:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Original issue's description:
> [css-grid] Implement auto-repeat computation
>
> We added support for parsing and style for the new auto-repeat syntax. This
> CL actually implements the feature by computing the number of auto-repeat
> tracks that will be part of the explicit grid depending on the available
> size on the corresponding axis.
>
> Note that this CL does not drop the empty tracks, i.e., auto-fit will work
> exactly as auto-fill until the empty track removal is implemented.
>
> Test results are not totally correct yet because we need to add the line
> names to the computed style. As that requires a rather large piece of code
> it will be done in a follow up patch. Track sizes are correct though.
>
> BUG=589460
>
> Committed: https://crrev.com/7b1b0f17c7a1eac0283fc9daa519328a42e0139f
> Cr-Commit-Position: refs/heads/master@{#389456}
TBR=cbiesinger@chromium.org,timloh@chromium.org,rune@opera.com,rego@igalia.co...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589460
==========
to
==========
Revert of [css-grid] Implement auto-repeat computation (patchset #6 id:120001 of
https://codereview.chromium.org/1895443002/ )
Reason for revert:
Appeared to cause lots of fast/css-grid-layout test failures on WebKit Linux
MSAN:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/b...
Original issue's description:
> [css-grid] Implement auto-repeat computation
>
> We added support for parsing and style for the new auto-repeat syntax. This
> CL actually implements the feature by computing the number of auto-repeat
> tracks that will be part of the explicit grid depending on the available
> size on the corresponding axis.
>
> Note that this CL does not drop the empty tracks, i.e., auto-fit will work
> exactly as auto-fill until the empty track removal is implemented.
>
> Test results are not totally correct yet because we need to add the line
> names to the computed style. As that requires a rather large piece of code
> it will be done in a follow up patch. Track sizes are correct though.
>
> BUG=589460
>
> Committed: https://crrev.com/7b1b0f17c7a1eac0283fc9daa519328a42e0139f
> Cr-Commit-Position: refs/heads/master@{#389456}
TBR=cbiesinger@chromium.org,timloh@chromium.org,rune@opera.com,rego@igalia.co...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589460
Committed: https://crrev.com/9307c20948380712fc0abfe53a01844e2e103fbc
Cr-Commit-Position: refs/heads/master@{#389504}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9307c20948380712fc0abfe53a01844e2e103fbc Cr-Commit-Position: refs/heads/master@{#389504}
4 years, 7 months ago
(2016-04-25 16:52:54 UTC)
#6
Issue 1920953002: Revert of [css-grid] Implement auto-repeat computation
(Closed)
Created 4 years, 7 months ago by Charlie Reis
Modified 4 years, 7 months ago
Reviewers: cbiesinger, Timothy Loh, rune, Manuel Rego, svillar
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0