Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: recipe_modules/bot_update/example.py

Issue 1920933002: patch_root hacks cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@P300
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/bot_update/example.py
diff --git a/recipe_modules/bot_update/example.py b/recipe_modules/bot_update/example.py
index 6aea997feafad0a30d4a3057c36d217a4d5e91dd..7bdef5ba0e4a2aa93178a56344eb2f137b47b05e 100644
--- a/recipe_modules/bot_update/example.py
+++ b/recipe_modules/bot_update/example.py
@@ -34,9 +34,6 @@ def RunSteps(api):
root_solution_revision = api.properties.get('root_solution_revision')
suffix = api.properties.get('suffix')
gerrit_no_reset = True if api.properties.get('gerrit_no_reset') else False
- # TODO(tandrii): remove this after transition. http://crbug.com/605563.
- crbug605563 = ('TODO(TANDRII): REMOVE THIS TRANSITION TO patch_projects'
- if api.properties.get('crbug605563') else None)
api.bot_update.ensure_checkout(force=force,
no_shallow=no_shallow,
patch=patch,
@@ -46,8 +43,7 @@ def RunSteps(api):
clobber=clobber,
root_solution_revision=root_solution_revision,
suffix=suffix,
- gerrit_no_reset=gerrit_no_reset,
- patch_root=crbug605563)
+ gerrit_no_reset=gerrit_no_reset)
def GenTests(api):
@@ -79,15 +75,6 @@ def GenTests(api):
patchset=654321,
patch_url='http://src.chromium.org/foo/bar'
)
- yield api.test('tryjob_crbug605563') + api.properties(
- mastername='tryserver.chromium.linux',
- buildername='linux_rel',
- slavename='totallyaslave-c4',
- issue=12345,
- patchset=654321,
- patch_url='http://src.chromium.org/foo/bar',
- crbug605563=True,
- )
yield api.test('trychange') + api.properties(
mastername='tryserver.chromium.linux',
buildername='linux_rel',
@@ -179,9 +166,7 @@ def GenTests(api):
)
yield api.test('tryjob_v8_head_by_default') + api.properties.tryserver(
patch_project='v8',
- crbug605563=True,
)
yield api.test('tryjob_gerrit_angle') + api.properties.tryserver_gerrit(
full_project_name='angle/angle',
- crbug605563=True,
)
« no previous file with comments | « recipe_modules/bot_update/api.py ('k') | recipe_modules/bot_update/example.expected/tryjob_crbug605563.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698