Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: recipe_modules/bot_update/api.py

Issue 1920933002: patch_root hacks cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@P300
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_modules/bot_update/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/bot_update/api.py
diff --git a/recipe_modules/bot_update/api.py b/recipe_modules/bot_update/api.py
index a494e8b318038cde2fe4db9c3e64bf5a744442c2..8b3a35b0b8486556235c5a0834b87291d5329a39 100644
--- a/recipe_modules/bot_update/api.py
+++ b/recipe_modules/bot_update/api.py
@@ -57,7 +57,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
patch=True, update_presentation=True,
force=False, patch_root=None, no_shallow=False,
with_branch_heads=False, refs=None,
- patch_project_roots=None, patch_oauth2=False,
+ patch_oauth2=False,
output_manifest=True, clobber=False,
root_solution_revision=None, rietveld=None, issue=None,
patchset=None, gerrit_no_reset=False, **kwargs):
@@ -85,14 +85,7 @@ class BotUpdateApi(recipe_api.RecipeApi):
# Construct our bot_update command. This basically be inclusive of
# everything required for bot_update to know:
root = patch_root
- if (root == 'TODO(TANDRII): REMOVE THIS TRANSITION TO patch_projects' or
- root is None):
- # This special condition is here for initial rollout of this code,
- # because it's hard to test this change without rolling into build
- # repository.
- # After the switch to new code is complete, this special TODOstring will
- # be removed in favor of "root is None"
- assert patch_project_roots is None
+ if root is None:
root = self.m.gclient.calculate_patch_root(
self.m.properties.get('patch_project'), cfg)
« no previous file with comments | « no previous file | recipe_modules/bot_update/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698