Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1920933002: patch_root hacks cleanup. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@P300
Target Ref:
refs/heads/master
Visibility:
Public.

Description

patch_root hacks cleanup. Removes deprecated patch_project_roots in bot_update, and the TODOs used for migration. Depends: https://codereview.chromium.org/1913863002 R=phajdan.jr@chromium.org,machenbach@chromium.org BUG=605563 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -84 lines) Patch
M recipe_modules/bot_update/api.py View 2 chunks +2 lines, -9 lines 0 comments Download
M recipe_modules/bot_update/example.py View 4 chunks +1 line, -16 lines 0 comments Download
D recipe_modules/bot_update/example.expected/tryjob_crbug605563.json View 1 chunk +0 lines, -59 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-25 15:47:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920933002/1
4 years, 8 months ago (2016-04-25 15:47:58 UTC) #3
Paweł Hajdan Jr.
LGTM
4 years, 8 months ago (2016-04-25 15:54:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920933002/1
4 years, 8 months ago (2016-04-25 17:37:28 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 17:40:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300153

Powered by Google App Engine
This is Rietveld 408576698