Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1920923003: Revert "bluetooth: Create bluetooth_metrics_hash tool." (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "bluetooth: Create bluetooth_metrics_hash tool." This reverts commit a764c35855b9595f80c36ee48fd9cfa2c9b1a724. Caused a compile error on Win x64 Builder (dbg): https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/21170 BUG=none TBR=scheib,jyasskin,holte,dpranke NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/2d99834229eed64569f434b84cd7a38353095a3e Cr-Commit-Position: refs/heads/master@{#389598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -82 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/bluetooth/bluetooth_metrics.cc View 1 chunk +5 lines, -13 lines 0 comments Download
D content/browser/bluetooth/tools/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D content/browser/bluetooth/tools/bluetooth_metrics_hash.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Charlie Reis
Reverting manually, since the revert button isn't working on this CL.
4 years, 8 months ago (2016-04-25 23:09:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920923003/1
4 years, 8 months ago (2016-04-25 23:10:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920923003/1
4 years, 8 months ago (2016-04-25 23:20:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 23:21:26 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2d99834229eed64569f434b84cd7a38353095a3e Cr-Commit-Position: refs/heads/master@{#389598}
4 years, 8 months ago (2016-04-25 23:22:32 UTC) #13
Dirk Pranke
lgtm. unfortunately, the way the trybots are configured, the new binary wouldn't have actually been ...
4 years, 8 months ago (2016-04-25 23:34:27 UTC) #14
scheib
4 years, 8 months ago (2016-04-26 04:48:08 UTC) #15
Message was sent while issue was closed.
LGTM. Yeah, ;\ sigh.

Powered by Google App Engine
This is Rietveld 408576698