scripts/slave/recipe_modules/v8/api.py - Issue 1920903002: V8: offload patch_root handling to gclient and bot_update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1920903002: V8: offload patch_root handling to gclient and bot_update. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/v8/api.py

diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py

index 6e70035c1dc29e43ca59cbfe3537af3ba4f4ca4d..76787da24c662b7e67a8175619331212886d6d62 100644

--- a/scripts/slave/recipe_modules/v8/api.py

+++ b/scripts/slave/recipe_modules/v8/api.py

@@ -163,10 +163,9 @@ class V8Api(recipe_api.RecipeApi):

solution.revision = revision

update_step = self.m.bot_update.ensure_checkout(

no_shallow=True,

- patch_root=[None, 'v8'][bool(self.m.tryserver.is_tryserver)],

+ patch_root='TODO(TANDRII): REMOVE THIS TRANSITION TO patch_projects',

output_manifest=True,

with_branch_heads=needs_branch_heads,

- patch_project_roots={'v8': []},

**kwargs)

assert update_step.json.output['did_run']

« no previous file with comments | « no previous file | no next file » | no next file with comments »