Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1920903002: V8: offload patch_root handling to gclient and bot_update. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-25 15:33:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920903002/1
4 years, 8 months ago (2016-04-25 15:33:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 15:38:27 UTC) #5
tandrii(chromium)
PTAL This is ready to land and should have no impact. Afterwards: https://codereview.chromium.org/1919863003/#ps1
4 years, 8 months ago (2016-04-25 15:48:06 UTC) #6
Paweł Hajdan Jr.
LGTM
4 years, 8 months ago (2016-04-25 15:58:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920903002/1
4 years, 8 months ago (2016-04-25 15:59:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300148
4 years, 8 months ago (2016-04-25 16:03:12 UTC) #14
Michael Achenbach
lgtm
4 years, 8 months ago (2016-04-25 16:17:47 UTC) #15
tandrii(chromium)
I've shceduled trys on v8 tryserver: https://codereview.chromium.org/1339923005/, and they are OK., though chrome trybots are ...
4 years, 8 months ago (2016-04-25 16:18:19 UTC) #16
tandrii(chromium)
4 years, 8 months ago (2016-04-25 16:56:14 UTC) #17
Message was sent while issue was closed.
On 2016/04/25 16:18:19, tandrii(chromium) wrote:
> I've shceduled trys on v8 tryserver:
> https://codereview.chromium.org/1339923005/, and they are OK., though chrome
> trybots are still pending.

OK, it's done.

Powered by Google App Engine
This is Rietveld 408576698