Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1920883003: Ship try-finally optimization in Turbofan. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Benedikt Meurer, mvstanton, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship try-finally optimization in Turbofan. Committed: https://crrev.com/101260d3048fd99520906e755ef545c3cf2a3c03 Cr-Commit-Position: refs/heads/master@{#35804}

Patch Set 1 #

Patch Set 2 : Fix a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-profile-generator.cc View 1 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-04-26 13:36:26 UTC) #2
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-26 14:48:52 UTC) #3
Benedikt Meurer
LGTM!
4 years, 8 months ago (2016-04-26 16:46:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920883003/20001
4 years, 7 months ago (2016-04-27 04:27:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 04:28:58 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 04:29:15 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/101260d3048fd99520906e755ef545c3cf2a3c03
Cr-Commit-Position: refs/heads/master@{#35804}

Powered by Google App Engine
This is Rietveld 408576698