Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1920873003: Include file names in trace-opt/trace-deopt output (Closed)

Created:
4 years, 8 months ago by mattloring
Modified:
4 years, 7 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include file names in trace-opt/trace-deopt output Trace-opt/trace-deopt output is ambiguous if multiple functions share the same name. This change adds file names to this output behind the --trace-file-names flag to reduce this ambiguity. R=ofrobots@google.com BUG= Committed: https://crrev.com/05e92849430eaf34f4fb7fd762242d90fc75e016 Cr-Commit-Position: refs/heads/master@{#35824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mattloring
4 years, 8 months ago (2016-04-25 20:51:53 UTC) #1
jochen (gone - plz use gerrit)
Jakob is a better reviewer for this than me.
4 years, 7 months ago (2016-04-27 11:50:05 UTC) #5
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-04-27 12:50:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920873003/1
4 years, 7 months ago (2016-04-27 14:01:40 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 14:26:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920873003/1
4 years, 7 months ago (2016-04-27 14:47:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 14:49:24 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 14:50:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05e92849430eaf34f4fb7fd762242d90fc75e016
Cr-Commit-Position: refs/heads/master@{#35824}

Powered by Google App Engine
This is Rietveld 408576698