[Autofill] Do not show Autocomplete suggestions for credit card fields.

[Autofill] Do not show Autocomplete suggestions for credit card fields.

BUG=605680
TEST=AutofillManagerTest

Committed: https://crrev.com/1b3eeb653a354261f820bab9658c746efe5e8cde
Cr-Commit-Position: refs/heads/master@{#390104}

[Mathieu, 2016-04-26 20:31:01]

mathp@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Mathieu, 2016-04-26 20:31:02]

Hi Justin, PTAL!

[Justin Donnelly, 2016-04-26 21:19:00]

Nice! lgtm with one suggestion

https://codereview.chromium.org/1920863006/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/1920863006/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_manager.cc:558:
autofill_field->Type().group() == CREDIT_CARD)) {
How about carving out an exception for Type() == CREDIT_CARD_NAME_FULL? That's
not sensitive and would be helpful when filling out a cc form without autofill.

[Mathieu, 2016-04-27 15:31:29]

Thanks!

https://codereview.chromium.org/1920863006/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/1920863006/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_manager.cc:558:
autofill_field->Type().group() == CREDIT_CARD)) {
On 2016/04/26 21:19:00, Justin Donnelly wrote:
> How about carving out an exception for Type() == CREDIT_CARD_NAME_FULL? That's
> not sensitive and would be helpful when filling out a cc form without
autofill.

Sure, I went with restricting the exclusion to CVC, number and expiration.

[Mathieu, 2016-04-27 15:31:32]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-04-27 15:31:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdonnelly@chromium.org
Link to the patchset: https://codereview.chromium.org/1920863006/#ps40001
(title: "no autocomplete on cc number, exp or cvc")

[commit-bot: I haz the power, 2016-04-27 15:32:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920863006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920863006/40001

[commit-bot: I haz the power, 2016-04-27 16:47:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:10:39]

Patchset 3 (id:??) landed as
https://crrev.com/1b3eeb653a354261f820bab9658c746efe5e8cde
Cr-Commit-Position: refs/heads/master@{#390104}

[commit-bot: I haz the power, 2016-04-30 17:50:27]

Description was changed from

==========
[Autofill] Do not show Autocomplete suggestions for credit card fields.

BUG=605680
TEST=AutofillManagerTest
==========

to

==========
[Autofill] Do not show Autocomplete suggestions for credit card fields.

BUG=605680
TEST=AutofillManagerTest

Committed: https://crrev.com/1b3eeb653a354261f820bab9658c746efe5e8cde
Cr-Commit-Position: refs/heads/master@{#390104}
==========