Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1920863003: Roll v8 to 0ff89ea7 and update gyp references (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 3 chunks +6 lines, -6 lines 0 comments Download
M samples/samples.gyp View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920863003/1
4 years, 8 months ago (2016-04-26 08:58:29 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 8 months ago (2016-04-26 08:58:30 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920863003/1
4 years, 8 months ago (2016-04-26 09:04:09 UTC) #6
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 8 months ago (2016-04-26 09:04:11 UTC) #8
Michael Achenbach
PTAL
4 years, 8 months ago (2016-04-26 09:14:14 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-26 09:22:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920863003/1
4 years, 8 months ago (2016-04-26 10:12:18 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 10:12:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3081cc07898dd19a0a00d406ac3555c11194...

Powered by Google App Engine
This is Rietveld 408576698