Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1920843007: Update chrome_rev (Closed)

Created:
4 years, 7 months ago by Roland McGrath
Modified:
4 years, 7 months ago
Reviewers:
Petr Hosek, bradnelson
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Update chrome_rev This updates chrome_rev and dependent entries in DEPS. BUG= none TEST= trybots R=phosek@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/0d82966c6f04a6db6cb08299dbe4ed8f971d0121

Patch Set 1 #

Patch Set 2 : new revs; drop gyp #

Patch Set 3 : turns out some chromium scripts need gyp to exist #

Patch Set 4 : really restore gyp in DEPS this time #

Patch Set 5 : debugging hack #

Patch Set 6 : typo in hack #

Patch Set 7 : more debugging #

Patch Set 8 : just punt GYP_MSVS_VERSION setting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M DEPS View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M buildbot/buildbot_lib.py View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Roland McGrath
4 years, 7 months ago (2016-04-26 22:45:14 UTC) #1
Roland McGrath
The Windows bots fail in some strange way that I'm assuming is a mismatch between ...
4 years, 7 months ago (2016-04-26 23:35:24 UTC) #3
Roland McGrath
PTAL This one at least got past the GN build on a Windows bot. Note ...
4 years, 7 months ago (2016-04-28 21:50:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920843007/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920843007/140001
4 years, 7 months ago (2016-04-28 21:50:46 UTC) #6
Petr Hosek
lgtm
4 years, 7 months ago (2016-04-28 22:24:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 22:44:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920843007/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920843007/140001
4 years, 7 months ago (2016-04-28 22:48:56 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 22:50:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/native_client/src/native_client/+/0d82966c6...

Powered by Google App Engine
This is Rietveld 408576698