Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1920843004: Delete the font loading experiment code (Closed)

Created:
4 years, 8 months ago by Ilya Kulshin
Modified:
4 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the font loading experiment code This experiment has been on canary for a week, and unambiguously demonstrates that using memory mapped files is better for font loading perf. Using a memory mapped file improves font family load time by up to 5-25%, and even shows a tiny improvement in overall startup time. BUG=577387 Committed: https://crrev.com/1687197af8e366889cd16cbd3d4116af17a790b7 Cr-Commit-Position: refs/heads/master@{#389824}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M content/child/dwrite_font_proxy/dwrite_font_proxy_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ilya Kulshin
ptal
4 years, 8 months ago (2016-04-25 21:48:17 UTC) #3
scottmg
lgtm
4 years, 8 months ago (2016-04-25 21:51:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920843004/20001
4 years, 7 months ago (2016-04-26 18:11:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-04-26 18:53:00 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 18:54:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1687197af8e366889cd16cbd3d4116af17a790b7
Cr-Commit-Position: refs/heads/master@{#389824}

Powered by Google App Engine
This is Rietveld 408576698