Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 1920843002: Test: deleting RTM before BVR does not leak resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer_unittest.cc
diff --git a/android_webview/browser/browser_view_renderer_unittest.cc b/android_webview/browser/browser_view_renderer_unittest.cc
index aa7d51872d2e7d638d079bcf07cd12779189bdfb..bb7bcdba2f1b9faaabb08efe10fc3e53c811f3f7 100644
--- a/android_webview/browser/browser_view_renderer_unittest.cc
+++ b/android_webview/browser/browser_view_renderer_unittest.cc
@@ -20,9 +20,7 @@ namespace android_webview {
class SmokeTest : public RenderingTest {
void StartTest() override { browser_view_renderer_->PostInvalidate(); }
- void DidDrawOnRT(RenderThreadManager* functor) override {
- EndTest();
- }
+ void DidDrawOnRT() override { EndTest(); }
};
RENDERING_TEST_F(SmokeTest);
@@ -49,9 +47,8 @@ class ClearViewTest : public RenderingTest {
}
}
- void DidDrawOnRT(RenderThreadManager* functor) override {
- EndTest();
- }
+ void DidDrawOnRT() override { EndTest(); }
+
private:
int on_draw_count_;
};
@@ -87,8 +84,7 @@ class TestAnimateInAndOutOfScreen : public RenderingTest {
on_draw_count_++;
}
- bool WillDrawOnRT(RenderThreadManager* functor,
- AwDrawGLInfo* draw_info) override {
+ bool WillDrawOnRT(AwDrawGLInfo* draw_info) override {
if (draw_gl_count_on_rt_ == 1) {
draw_gl_count_on_rt_++;
ui_task_runner_->PostTask(
@@ -109,9 +105,7 @@ class TestAnimateInAndOutOfScreen : public RenderingTest {
return true;
}
- void DidDrawOnRT(RenderThreadManager* functor) override {
- draw_gl_count_on_rt_++;
- }
+ void DidDrawOnRT() override { draw_gl_count_on_rt_++; }
bool DrawConstraintsEquals(
const ParentCompositorDrawConstraints& constraints1,
@@ -253,6 +247,7 @@ class SwitchOutputSurfaceIdTest : public RenderingTest {
}
void CheckResults() {
+ GetCompositorFrameConsumer()->DeleteHardwareRendererOnUI();
window_->Detach();
window_.reset();
« no previous file with comments | « no previous file | android_webview/browser/test/fake_window.h » ('j') | android_webview/browser/test/fake_window.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698