Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1920833003: Use VulkanBrowserCompositorOS only for Aura. (Closed)

Created:
4 years, 7 months ago by sohanjg
Modified:
4 years, 7 months ago
Reviewers:
David Yen, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use VulkanBrowserCompositorOS only for Aura. BUG=582558 Committed: https://crrev.com/86c41c7aaf668b2811da30ffa01d28f47648e852 Cr-Commit-Position: refs/heads/master@{#389790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M content/browser/BUILD.gn View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sohanjg
Please take a look, thanks. Will also add VulkanOutputSurfaceWithoutParent for Android as a follow-up.
4 years, 7 months ago (2016-04-26 11:07:11 UTC) #2
piman
lgtm
4 years, 7 months ago (2016-04-26 14:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920833003/1
4 years, 7 months ago (2016-04-26 14:39:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 15:33:32 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 15:34:40 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/86c41c7aaf668b2811da30ffa01d28f47648e852
Cr-Commit-Position: refs/heads/master@{#389790}

Powered by Google App Engine
This is Rietveld 408576698