Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h

Issue 1920833002: Don't force layout of descendants of SVG containers needing self-layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify comments. Make some methods private. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h
index a024b5ed48d2b4a3c25f7e27a7d4e12fc8d2dac3..1c0608fe64edaab69039e8ba14b6f19034351376 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h
@@ -43,9 +43,6 @@ public:
// Calculates marker boundaries, mapped to the target element's coordinate space
FloatRect markerBoundaries(const AffineTransform& markerTransformation) const;
- void layout() override;
- void calcViewport() override;
-
const AffineTransform& localToSVGParentTransform() const override;
AffineTransform markerTransformation(const FloatPoint& origin, float angle, float strokeWidth) const;
@@ -60,6 +57,10 @@ public:
LayoutSVGResourceType resourceType() const override { return s_resourceType; }
private:
+ void layout() override;
+ void calcViewport() override;
+ bool calculateLocalTransform() override;
+
// Generates a transformation matrix usable to layout marker content. Handles scaling the marker content
// acording to SVGs markerUnits="strokeWidth" concept, when a strokeWidth value != -1 is passed in.
AffineTransform markerContentTransformation(const AffineTransform& contentTransformation, const FloatPoint& origin, float strokeWidth = -1) const;

Powered by Google App Engine
This is Rietveld 408576698