Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h

Issue 1920833002: Don't force layout of descendants of SVG containers needing self-layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify comments. Make some methods private. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009 Google, Inc. All rights reserved. 4 * Copyright (C) 2009 Google, Inc. All rights reserved.
5 * Copyright (C) 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 29 matching lines...) Expand all
40 void computeIntrinsicSizingInfo(IntrinsicSizingInfo&) const override; 40 void computeIntrinsicSizingInfo(IntrinsicSizingInfo&) const override;
41 41
42 // If you have a LayoutSVGRoot, use firstChild or lastChild instead. 42 // If you have a LayoutSVGRoot, use firstChild or lastChild instead.
43 void slowFirstChild() const = delete; 43 void slowFirstChild() const = delete;
44 void slowLastChild() const = delete; 44 void slowLastChild() const = delete;
45 45
46 LayoutObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); } 46 LayoutObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
47 LayoutObject* lastChild() const { ASSERT(children() == virtualChildren()); r eturn children()->lastChild(); } 47 LayoutObject* lastChild() const { ASSERT(children() == virtualChildren()); r eturn children()->lastChild(); }
48 48
49 bool isLayoutSizeChanged() const { return m_isLayoutSizeChanged; } 49 bool isLayoutSizeChanged() const { return m_isLayoutSizeChanged; }
50 bool didScreenScaleFactorChange() const { return m_didScreenScaleFactorChang e; }
50 void setNeedsBoundariesUpdate() override { m_needsBoundariesOrTransformUpdat e = true; } 51 void setNeedsBoundariesUpdate() override { m_needsBoundariesOrTransformUpdat e = true; }
51 void setNeedsTransformUpdate() override { m_needsBoundariesOrTransformUpdate = true; } 52 void setNeedsTransformUpdate() override { m_needsBoundariesOrTransformUpdate = true; }
52 53
53 IntSize containerSize() const { return m_containerSize; } 54 IntSize containerSize() const { return m_containerSize; }
54 void setContainerSize(const IntSize& containerSize) 55 void setContainerSize(const IntSize& containerSize)
55 { 56 {
56 // SVGImage::draw() does a view layout prior to painting, 57 // SVGImage::draw() does a view layout prior to painting,
57 // and we need that layout to know of the new size otherwise 58 // and we need that layout to know of the new size otherwise
58 // the layout may be incorrectly using the old size. 59 // the layout may be incorrectly using the old size.
59 if (m_containerSize != containerSize) 60 if (m_containerSize != containerSize)
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 118
118 LayoutObjectChildList m_children; 119 LayoutObjectChildList m_children;
119 IntSize m_containerSize; 120 IntSize m_containerSize;
120 FloatRect m_objectBoundingBox; 121 FloatRect m_objectBoundingBox;
121 bool m_objectBoundingBoxValid; 122 bool m_objectBoundingBoxValid;
122 FloatRect m_strokeBoundingBox; 123 FloatRect m_strokeBoundingBox;
123 FloatRect m_paintInvalidationBoundingBox; 124 FloatRect m_paintInvalidationBoundingBox;
124 mutable AffineTransform m_localToParentTransform; 125 mutable AffineTransform m_localToParentTransform;
125 AffineTransform m_localToBorderBoxTransform; 126 AffineTransform m_localToBorderBoxTransform;
126 bool m_isLayoutSizeChanged : 1; 127 bool m_isLayoutSizeChanged : 1;
128 bool m_didScreenScaleFactorChange : 1;
127 bool m_needsBoundariesOrTransformUpdate : 1; 129 bool m_needsBoundariesOrTransformUpdate : 1;
128 bool m_hasBoxDecorationBackground : 1; 130 bool m_hasBoxDecorationBackground : 1;
129 mutable bool m_hasNonIsolatedBlendingDescendants : 1; 131 mutable bool m_hasNonIsolatedBlendingDescendants : 1;
130 mutable bool m_hasNonIsolatedBlendingDescendantsDirty : 1; 132 mutable bool m_hasNonIsolatedBlendingDescendantsDirty : 1;
131 }; 133 };
132 134
133 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGRoot, isSVGRoot()); 135 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGRoot, isSVGRoot());
134 136
135 } // namespace blink 137 } // namespace blink
136 138
137 #endif // LayoutSVGRoot_h 139 #endif // LayoutSVGRoot_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698