Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Issue 1920793004: Remove unused proto import for LayerTreeHost. (Closed)

Created:
4 years, 8 months ago by nyquist
Modified:
4 years, 8 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused proto import for LayerTreeHost. The initial commit of the layer_tree_host.proto https://codereview.chromium.org/1519293002 included an unused import for layer_tree_settings.proto, since LayerTreeHost message does not refer to LayerTreeSettings. The LayerTreeSettings are instead used for the CompositorMessageToImpl messages and specifically the InitializeImpl message. This CL just removes the unused import to clean up code and remove build spam. BUG=606393 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/63058ab766b06470a17d417577e505964560c6df Cr-Commit-Position: refs/heads/master@{#389542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M cc/proto/layer_tree_host.proto View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
nyquist
vmpstr: PTAL See bug for details.
4 years, 8 months ago (2016-04-25 18:29:11 UTC) #3
vmpstr
lgtm
4 years, 8 months ago (2016-04-25 18:37:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920793004/1
4 years, 8 months ago (2016-04-25 18:45:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 19:45:23 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 19:46:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63058ab766b06470a17d417577e505964560c6df
Cr-Commit-Position: refs/heads/master@{#389542}

Powered by Google App Engine
This is Rietveld 408576698