Issue 192079: Bookmark context menu: pass the correct parent to the bookmark editor....

Issue 192079: Bookmark context menu: pass the correct parent to the bookmark editor.... (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bookmark context menu: pass the correct parent to the bookmark editor. BUG=21360 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26062

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_context_menu_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/gtk/bookmark_context_menu.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 3 months ago (2009-09-12 00:24:04 UTC) #2

LGTM

On Fri, Sep 11, 2009 at 5:05 PM,  <estade@chromium.org> wrote:
> Reviewers: Ben Goodger, Elliot Glaysher,
>
> Description:
> Bookmark context menu: pass the correct parent to the bookmark editor.
>
> BUG=3D21360
> TEST=3Dsee bug
>
>
> Please review this at http://codereview.chromium.org/192079
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/bookmarks/bookmark_context_menu_controller.cc
> =A0M =A0 =A0 chrome/browser/gtk/bookmark_context_menu.cc
>
>
> Index: chrome/browser/gtk/bookmark_context_menu.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/gtk/bookmark_context_menu.cc (revision 26012)
> +++ chrome/browser/gtk/bookmark_context_menu.cc (working copy)
> @@ -337,7 +337,7 @@
> =A0 =A0 =A0 =A0 =A0 editor_config =3D BookmarkEditor::SHOW_TREE;
> =A0 =A0 =A0 =A0 else
> =A0 =A0 =A0 =A0 =A0 editor_config =3D BookmarkEditor::NO_TREE;
> - =A0 =A0 =A0 =A0BookmarkEditor::Show(wnd_, profile_, NULL, selection_[0]=
,
> + =A0 =A0 =A0 =A0BookmarkEditor::Show(wnd_, profile_, parent_, selection_=
[0],
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0editor_config,=
 NULL);
> =A0#else
> =A0 =A0 =A0 =A0 NOTIMPLEMENTED();
> Index: chrome/browser/bookmarks/bookmark_context_menu_controller.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/bookmarks/bookmark_context_menu_controller.cc
> =A0(revision 26012)
> +++ chrome/browser/bookmarks/bookmark_context_menu_controller.cc
> =A0(working copy)
> @@ -316,7 +316,7 @@
> =A0 =A0 =A0 =A0 =A0 editor_config =3D BookmarkEditor::SHOW_TREE;
> =A0 =A0 =A0 =A0 else
> =A0 =A0 =A0 =A0 =A0 editor_config =3D BookmarkEditor::NO_TREE;
> - =A0 =A0 =A0 =A0BookmarkEditor::Show(parent_window_, profile_, NULL, sel=
ection_[0],
> + =A0 =A0 =A0 =A0BookmarkEditor::Show(parent_window_, profile_, parent_,
> selection_[0],
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0editor_config,=
 NULL);
> =A0 =A0 =A0 } else {
> =A0 =A0 =A0 =A0 EditFolderController::Show(profile_, parent_window_, sele=
ction_[0],
>
>
>

Expand Messages | Collapse Messages