Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1920773002: Remove DhtmlPageSet (Closed)

Created:
4 years, 8 months ago by kouhei (in TOK)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DhtmlPageSet DhtmlPageSet is currently only used on ChromeOS bots, and contains super old artificial tests inherited from Mozilla. Now speed-infra CrOS bots are capable of running regular page_sets like typical_25, remove the DHTML page set and its page cycler v1 benchmark per comment. BUG=606277 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/599a55f4169c18ff43626a89b92d6695e2b91a32 Cr-Commit-Position: refs/heads/master@{#389476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/perf/page_sets/page_cycler/dhtml.py View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kouhei (in TOK)
4 years, 8 months ago (2016-04-25 08:02:52 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920773002/1
4 years, 8 months ago (2016-04-25 08:03:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 12:29:43 UTC) #8
nednguyen
lgtm
4 years, 8 months ago (2016-04-25 14:47:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920773002/1
4 years, 8 months ago (2016-04-25 14:47:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 14:52:05 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/599a55f4169c18ff43626a89b92d6695e2b91a32 Cr-Commit-Position: refs/heads/master@{#389476}
4 years, 8 months ago (2016-04-25 14:53:25 UTC) #15
nednguyen
4 years, 7 months ago (2016-04-27 00:23:27 UTC) #16
Message was sent while issue was closed.
On 2016/04/25 14:53:25, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/599a55f4169c18ff43626a89b92d6695e2b91a32
> Cr-Commit-Position: refs/heads/master@{#389476}

I forgot but we also should delete '../../../../data/page_cycler/dhtml'

Powered by Google App Engine
This is Rietveld 408576698