Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1920763004: Support 'mac' architecture for system Flash installs on OS X. (Closed)

Created:
4 years, 8 months ago by Will Harris
Modified:
4 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support 'mac' architecture for system Flash installs OS X. While component updated manifest.json have "x64" as the x-ppapi-arch, the system PPAPI Flash install from Adobe has "mac" as the x-ppapi-arch. In order to correctly pick up the system Flash player on OS X, add support for both architectures. BUG=605983 TEST=run chromium on OS X with PPAPI Flash installed and verify Flash works. Committed: https://crrev.com/391d5d801dcc67144746630fa5d61540f4aeb86f Cr-Commit-Position: refs/heads/master@{#390553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/common/pepper_flash.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Will Harris
PTAL - another small Flash CL.
4 years, 8 months ago (2016-04-25 20:16:41 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
4 years, 7 months ago (2016-04-28 23:17:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920763004/1
4 years, 7 months ago (2016-04-28 23:19:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 01:18:44 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/391d5d801dcc67144746630fa5d61540f4aeb86f
Cr-Commit-Position: refs/heads/master@{#390553}

Powered by Google App Engine
This is Rietveld 408576698