Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1920763002: Remove unnecessary ExceptionCode.h inclusion (Closed)

Created:
4 years, 8 months ago by Srirama
Modified:
4 years, 8 months ago
Reviewers:
haraken, Dirk Pranke
CC:
chromium-reviews, shans, rjwright, tzik, blink-reviews-animation_chromium.org, sof, eae+blinkwatch, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, darktears, blink-reviews, rwlbuis, kinuko+fileapi, jshin+watch_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary ExceptionCode.h inclusion Though ExceptionCode.h is included, it's not used in some of the places Committed: https://crrev.com/fbc42e1ce18b28bac6b3659f5c61c7f8b499dfe5 Cr-Commit-Position: refs/heads/master@{#389458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMError.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIterator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeWalker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DOMParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/CryptoKey.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encoding/TextDecoder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Srirama
PTAL. While investigating crbug.com/585115 found that ExceptionCode.h is included in many places, though it is ...
4 years, 8 months ago (2016-04-25 07:40:15 UTC) #4
haraken
LGTM
4 years, 8 months ago (2016-04-25 07:53:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920763002/1
4 years, 8 months ago (2016-04-25 09:20:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 12:40:59 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 12:42:04 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fbc42e1ce18b28bac6b3659f5c61c7f8b499dfe5
Cr-Commit-Position: refs/heads/master@{#389458}

Powered by Google App Engine
This is Rietveld 408576698