Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1920753002: Make content_shell_test fit isolate naming convention. (Closed)

Created:
4 years, 8 months ago by ghost stip (do not use)
Modified:
4 years, 8 months ago
Reviewers:
jbudorick, no sievers
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make content_shell_test fit isolate naming convention. This allows use of the gtest test generator and easy swarming. https://chromereviews.googleplex.com/412157013/ is the corresponding internal build CL. BUG=525873 Committed: https://crrev.com/5d2e8c4d0b66f07bff4485999a4cdd1294a56762 Cr-Commit-Position: refs/heads/master@{#389614}

Patch Set 1 #

Patch Set 2 : Also update bb_device_steps.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -44 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell_test_apk.isolate View 1 chunk +20 lines, -16 lines 0 comments Download
D content/content_shell_test_apk_run.isolate View 1 chunk +0 lines, -25 lines 0 comments Download
A + content/content_shell_test_data.isolate View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
ghost stip (do not use)
ptal jbudorick: review sievers: content OWNERS
4 years, 8 months ago (2016-04-25 15:02:32 UTC) #6
jbudorick
tbh, while I like this change, it scares the hell out of me. Also, you ...
4 years, 8 months ago (2016-04-25 15:13:36 UTC) #7
ghost stip (do not use)
updated. ptal. syncing my downstream checkout now
4 years, 8 months ago (2016-04-25 16:35:18 UTC) #8
jbudorick
lgtm
4 years, 8 months ago (2016-04-25 16:38:41 UTC) #9
no sievers
lgtm stamp
4 years, 8 months ago (2016-04-25 21:38:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920753002/20001
4 years, 8 months ago (2016-04-25 22:03:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 23:38:34 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:40:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d2e8c4d0b66f07bff4485999a4cdd1294a56762
Cr-Commit-Position: refs/heads/master@{#389614}

Powered by Google App Engine
This is Rietveld 408576698