Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1920743003: small cleanup in dart:_runtime (Closed)

Created:
4 years, 8 months ago by Jennifer Messerly
Modified:
4 years, 8 months ago
Reviewers:
vsm, Harry Terkelsen
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

small cleanup in dart:_runtime there was LazyTagged thing that was not necessary R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6badc5505cd165e934a5a719b92037558bcee8e1

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +4 lines, -9 lines 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
M tool/input_sdk/private/ddc_runtime/rtti.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/types.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jennifer Messerly
4 years, 8 months ago (2016-04-25 21:26:16 UTC) #2
vsm
lgtm
4 years, 8 months ago (2016-04-26 20:12:55 UTC) #3
Harry Terkelsen
Why does the number of objects created when compiling cyclic_import_test seem to be non-deterministic?
4 years, 8 months ago (2016-04-26 20:18:23 UTC) #5
Jennifer Messerly
On 2016/04/26 20:18:23, Harry Terkelsen wrote: > Why does the number of objects created when ...
4 years, 8 months ago (2016-04-26 20:25:15 UTC) #6
Jennifer Messerly
4 years, 8 months ago (2016-04-27 00:58:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
6badc5505cd165e934a5a719b92037558bcee8e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698